lkml.org 
[lkml]   [2021]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5.10 038/146] mptcp: do not warn on bad input from the network
Hi!

> > > From: Paolo Abeni <pabeni@redhat.com>
> > >
> > > [ Upstream commit 61e710227e97172355d5f150d5c78c64175d9fb2 ]
> > >
> > > warn_bad_map() produces a kernel WARN on bad input coming
> > > from the network. Use pr_debug() to avoid spamming the system
> > > log.
> >
> > So... we switched from WARN _ONCE_ to pr_debug, as many times as we
> > detect the problem.
> >
> > Should this be pr_debug_once?
>
> Thank you for double checking this!
>
> In the MPTCP code, we use pr_debug() statements as a debug tool, e.g.
> when enabled, it could print per-packet info with no restriction.
>
> There are (a few) similar use in the plain TCP code.
>
> pr_debug() is not supposed to be enabled on any production system,
> while the WARN_ONCE could trigger automated tools for irrelevant
> network noise.

Correct me if I'm wrong, but I believe pr_debug will result in
messages being stored in the dmesg buffer, even on production
systems.

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-06-23 18:54    [W:0.107 / U:1.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site