Messages in this thread Patch in this message | | | Date | Wed, 23 Jun 2021 16:23:30 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH] phy: rockchip-inno-usb2: fix for_each_child.cocci warnings |
| |
From: kernel test robot <lkp@intel.com>
For_each_available_child_of_node should have of_node_put() before break around line 1184. The other jumps out of the loop do contain the put.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Sumera Priyadarsini <sylphrenadin@gmail.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> ---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0c18f29aae7ce3dadd26d8ee3505d07cc982df75 commit: 82c2d81361ecd142a54e84a9da1e287113314a4f coccinelle: iterators: Add for_each_child.cocci script :::::: branch date: 20 hours ago :::::: commit date: 8 months ago
Please take the patch only if it's a positive warning. Thanks!
phy-rockchip-inno-usb2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -1180,8 +1180,10 @@ static int rockchip_usb2phy_probe(struct
next_child: /* to prevent out of boundary */ - if (++index >= rphy->phy_cfg->num_ports) + if (++index >= rphy->phy_cfg->num_ports) { + of_node_put(child_np); break; + } }
provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
| |