Messages in this thread | | | Subject | Re: [PATCH net-next v4 04/10] net: sparx5: add port module support | From | Steen Hegelund <> | Date | Wed, 23 Jun 2021 15:05:25 +0200 |
| |
Hi Russell,
Thanks for your comment.
On Mon, 2021-06-21 at 15:33 +0100, Russell King (Oracle) wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi, > > On Tue, Jun 15, 2021 at 10:50:28AM +0200, Steen Hegelund wrote: > > +static int sparx5_port_pcs_low_set(struct sparx5 *sparx5, > > + struct sparx5_port *port, > > + struct sparx5_port_config *conf) > > +{ > > + bool sgmii = false, inband_aneg = false; > > + int err; > > + > > + if (!port->conf.has_sfp) { > > + sgmii = true; /* Phy is connnected to the MAC */ > > + } else { > > + if (conf->portmode == PHY_INTERFACE_MODE_SGMII || > > + conf->portmode == PHY_INTERFACE_MODE_QSGMII) > > + inband_aneg = true; /* Cisco-SGMII in-band-aneg */ > > + else if (conf->portmode == PHY_INTERFACE_MODE_1000BASEX && > > + conf->autoneg) > > + inband_aneg = true; /* Clause-37 in-band-aneg */ > > I have to wonder why the presence of inband aneg depends on whether > there's a SFP or not... We don't do that kind of thing in other > drivers, so what is different here?
Hmm. I have changed the implementation to use phylink_autoneg_inband() instead of a preconfigured value.
> > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
-- BR Steen
-=-=-=-=-=-=-=-=-=-=-=-=-=-= steen.hegelund@microchip.com
| |