On Wed, Jun 23, 2021 at 12:58:53PM +0200, Matteo Croce wrote:> +void inc_diskseq(struct gendisk *disk)> +{> + static atomic64_t diskseq;Please don't hide file scope variables in functions.Can you explain a little more why we need a global sequence count vsa per-disk one here?