lkml.org 
[lkml]   [2021]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] timer: Use static_branch_likely() for timers_nohz_active
On Tue, 22 Jun 2021 17:19:20 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:


>
>
> On Thu, May 13 2021 at 14:33, Jisheng Zhang wrote:
> > NOHZ is likely to be enabled, so use static_branch_likely() to
>
> Why is it likely to be enabled? Did you make a survey of the wider
> distro universe or what?

One more thought: maybe NOHZ is confusing, what I mean here is:
timers_nohz_active is likely to be true.

If I update the commit msg as the following, is it acceptable?

"timers_nohz_active is likely to be true, so use static_branch_likely() to
reflect this fact. This could improve the finally generated code
a bit for the most likely scenario, I.E save two "jmp" instructions."

Thanks

>
> > reflect this fact. This could improve the finally generated code
>
> could improve? Either it does or it does not.
>
> Thanks,
>
> tglx

\
 
 \ /
  Last update: 2021-06-23 12:42    [W:0.479 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site