Messages in this thread | | | Date | Thu, 24 Jun 2021 10:56:07 +0800 | From | Wong Vee Khee <> | Subject | Re: [PATCH net-next] net: phy: marvell10g: enable WoL for mv2110 |
| |
Hi Marek,
On Wed, Jun 23, 2021 at 11:38:54PM +0200, Marek Behun wrote: > On Wed, 23 Jun 2021 21:09:29 +0800 > Ling Pei Lee <pei.lee.ling@intel.com> wrote: > > > + /* Enable the WOL interrupt */ > > + ret = phy_set_bits_mmd(phydev, MDIO_MMD_VEND2, > > + MV_V2_PORT_INTR_MASK, > > + MV_V2_WOL_INTR_EN); > > + > > + if (ret < 0) > > + return ret; > > Hi, in addition to what Russell said, please remove the extra newline > between function call and return value check, i.e. instead of > ret = phy_xyz(...); > > if (ret) > return ret; > > ret = phy_xyz(...); > > if (ret) > return ret; > > do > ret = phy_xyz(...); > if (ret) > return ret; > > ret = phy_xyz(...); > if (ret) > return ret; > > This is how this driver does this everywhere else. > > Do you have a device that uses this WoL feature? >
Yes. We have Intel Elkhart Lake platform with Integrated Sypnosys MAC controller(STMMAC) paired with External PHY device (in this case the Marvell Alaska 88E2110).
BR, VK
| |