Messages in this thread | | | Subject | Re: [PATCH v4 01/10] scsi: ufs: Rename flags pm_op_in_progress and is_sys_suspended | From | Bart Van Assche <> | Date | Wed, 23 Jun 2021 15:41:32 -0700 |
| |
On 6/23/21 1:42 PM, Bjorn Andersson wrote: > On Wed 23 Jun 02:35 CDT 2021, Can Guo wrote: >> Rename pm_op_in_progress and is_sys_suspended to wlu_pm_op_in_progress and >> is_wlu_sys_suspended accordingly. > > This reflects what the change does, but the commit message is supposed > to capture "why".
What's even better is to describe both: what has been changed and also why a change has been made. See also https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes.
Thanks,
Bart.
| |