| Date | Wed, 23 Jun 2021 22:09:40 -0000 | From | "tip-bot2 for Thomas Gleixner" <> | Subject | [tip: x86/fpu] x86/fpu: Limit xstate copy size in xstateregs_set() |
| |
The following commit has been merged into the x86/fpu branch of tip:
Commit-ID: 07d6688b22e09be465652cf2da0da6bf86154df6 Gitweb: https://git.kernel.org/tip/07d6688b22e09be465652cf2da0da6bf86154df6 Author: Thomas Gleixner <tglx@linutronix.de> AuthorDate: Wed, 23 Jun 2021 14:01:35 +02:00 Committer: Borislav Petkov <bp@suse.de> CommitterDate: Wed, 23 Jun 2021 17:49:46 +02:00
x86/fpu: Limit xstate copy size in xstateregs_set()
If the count argument is larger than the xstate size, this will happily copy beyond the end of xstate.
Fixes: 91c3dba7dbc1 ("x86/fpu/xstate: Fix PTRACE frames for XSAVES") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Borislav Petkov <bp@suse.de> Reviewed-by: Andy Lutomirski <luto@kernel.org> Reviewed-by: Borislav Petkov <bp@suse.de> Link: https://lkml.kernel.org/r/20210623121452.120741557@linutronix.de --- arch/x86/kernel/fpu/regset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/fpu/regset.c b/arch/x86/kernel/fpu/regset.c index c413756..6bb8744 100644 --- a/arch/x86/kernel/fpu/regset.c +++ b/arch/x86/kernel/fpu/regset.c @@ -117,7 +117,7 @@ int xstateregs_set(struct task_struct *target, const struct user_regset *regset, /* * A whole standard-format XSAVE buffer is needed: */ - if ((pos != 0) || (count < fpu_user_xstate_size)) + if (pos != 0 || count != fpu_user_xstate_size) return -EFAULT; xsave = &fpu->state.xsave;
|