Messages in this thread Patch in this message | | | From | Marcin Wojtas <> | Date | Wed, 23 Jun 2021 23:58:14 +0200 | Subject | Re: [net-next: PATCH v3 4/6] net: mvmdio: add ACPI support |
| |
śr., 23 cze 2021 o 22:28 Andrew Lunn <andrew@lunn.ch> napisał(a): > > On Mon, Jun 21, 2021 at 07:30:26PM +0200, Marcin Wojtas wrote: > > This patch introducing ACPI support for the mvmdio driver by adding > > acpi_match_table with two entries: > > > > * "MRVL0100" for the SMI operation > > * "MRVL0101" for the XSMI mode > > Same as the freescale MDIO bus driver, you should add > > depends on FWNODE_MDIO > > Otherwise you might find randconfig builds end up with it disabled, > and then linker errors. >
The CONFIG_MVMDIO is selected by CONFIG_MV643XX_ETH and actually there is a real example of the previously discussed fallback to the mdiobus_register() (without DT/ACPI and now FWNODE_MDIO). I just checked and successfully built the kernel out of the dove_defconfig. I only needed below fix, that will be submitted in v4:
--- a/include/linux/fwnode_mdio.h +++ b/include/linux/fwnode_mdio.h @@ -40,7 +40,7 @@ static inline int fwnode_mdiobus_register(struct mii_bus *bus, * This way, we don't have to keep compat bits around in drivers. */
- return mdiobus_register(mdio); + return mdiobus_register(bus); } #endif
In order to leave dove_defconfig intact, I'd keep the current Kconfig shape for this driver. Thanks, Marcin
| |