lkml.org 
[lkml]   [2021]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [SMBDIRECT][PATCH] missing rc checks while waiting for SMB3 over RDMA events
Date
> Subject: [SMBDIRECT][PATCH] missing rc checks while waiting for SMB3 over
> RDMA events
>
> There were two places where we weren't checking for error
> (e.g. ERESTARTSYS) while waiting for rdma resolution.
>
> Addresses-Coverity: 1462165 ("Unchecked return value")
> Signed-off-by: Steve French <stfrench@microsoft.com>
>
> diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c index
> 10dfe5006792..ae07732f750f 100644
> --- a/fs/cifs/smbdirect.c
> +++ b/fs/cifs/smbdirect.c
> @@ -572,8 +572,11 @@ static struct rdma_cm_id *smbd_create_id(
> log_rdma_event(ERR, "rdma_resolve_addr() failed %i\n", rc);
> goto out;
> }
> - wait_for_completion_interruptible_timeout(
> + rc = wait_for_completion_interruptible_timeout(
> &info->ri_done, msecs_to_jiffies(RDMA_RESOLVE_TIMEOUT));
> + /* -ERESTARTSYS, returned when interrupted, is the only rc mentioned
> */
> + if (rc < 0)
> + goto out;
> rc = info->ri_rc;
> if (rc) {
> log_rdma_event(ERR, "rdma_resolve_addr() completed %i\n", rc);
> @@ -586,8 +589,10 @@ static struct rdma_cm_id *smbd_create_id(
> log_rdma_event(ERR, "rdma_resolve_route() failed %i\n", rc);
> goto out;
> }
> - wait_for_completion_interruptible_timeout(
> + rc = wait_for_completion_interruptible_timeout(
> &info->ri_done, msecs_to_jiffies(RDMA_RESOLVE_TIMEOUT));
> + if (rc < 0) /* e.g. if interrupted and returns -ERESTARTSYS */
> + goto out
> rc = info->ri_rc;
> if (rc) {
> log_rdma_event(ERR, "rdma_resolve_route() completed %i\n", rc);
>
>
> --
> Thanks,
>
> Steve

Reviewed-by: Long Li <longli@microsoft.com>
\
 
 \ /
  Last update: 2021-06-22 08:49    [W:0.354 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site