Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 22 Jun 2021 16:03:35 +0200 | Subject | Re: [PATCH v2 -next] riscv: mm: fix build errors caused by mk_pmd() |
| |
On Thu, Jun 17, 2021 at 11:28 AM Nanyong Sun <sunnanyong@huawei.com> wrote: > With "riscv: mm: add THP support on 64-bit", mk_pmd() function > introduce build errors, > 1.build with CONFIG_ARCH_RV32I=y: > arch/riscv/include/asm/pgtable.h: In function 'mk_pmd': > arch/riscv/include/asm/pgtable.h:513:9: error: implicit declaration of function 'pfn_pmd'; > did you mean 'pfn_pgd'? [-Werror=implicit-function-declaration] > > 2.build with CONFIG_SPARSEMEM=y && CONFIG_SPARSEMEM_VMEMMAP=n > arch/riscv/include/asm/pgtable.h: In function 'mk_pmd': > include/asm-generic/memory_model.h:64:14: error: implicit declaration of function 'page_to_section'; > did you mean 'present_section'? [-Werror=implicit-function-declaration] > > Move the definition of mk_pmd to pgtable-64.h to fix the first error. > Use macro definition instead of inline function for mk_pmd > to fix the second problem. It is similar to the mk_pte macro. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Nanyong Sun <sunnanyong@huawei.com>
Thanks, this fixes my rv32 build. Works fine with litex-rebase on VexRiscv. No regression on BeagleV Starlight-beta.
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |