| Date | Tue, 22 Jun 2021 15:51:53 +0200 | From | Borislav Petkov <> | Subject | Re: [patch V3 40/66] x86/fpu: Rename and sanitize fpu__save/copy() |
| |
On Fri, Jun 18, 2021 at 04:19:03PM +0200, Thomas Gleixner wrote: > Both functions are misnomed.
"Both function names are a misnomer." or simply "Both function are not named optimally."
> -int fpu__copy(struct task_struct *dst, struct task_struct *src) > +/* Clone current's FPU state on fork */ > +int fpu_clone(struct task_struct *dst) > { > + struct fpu *src_fpu = ¤t->thread.fpu; > struct fpu *dst_fpu = &dst->thread.fpu; > - struct fpu *src_fpu = &src->thread.fpu; > > + /* The new task's FPU state cannot be valid in the hardware. */ > dst_fpu->last_cpu = -1; > > if (!static_cpu_has(X86_FEATURE_FPU))
cpu_feature_enabled
while at it.
Regardless, looks nice.
Reviewed-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
|