Messages in this thread | | | Date | Tue, 22 Jun 2021 13:50:24 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regulator: da9052: Simplify checking DVC controlled regulators |
| |
On Fri, Jun 18, 2021 at 10:14:12PM +0800, Axel Lin wrote:
> Only DVC controlled regulators have activate_bit set, so just check > activate_bit we can know if the regulator is DVC controlled.
This feels a bit icky - what if the activate_bit for some variant were bit 0? I'm not sure we're likely to see new variants but even so the fact that 0 is a potentially valid value for the bit feels wrong. [unhandled content-type:application/pgp-signature] | |