Messages in this thread | | | Date | Tue, 22 Jun 2021 12:10:39 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v2 3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO |
| |
On Tue, Jun 22, 2021 at 10:05:40AM +0100, Mark Rutland wrote: > On Mon, Jun 21, 2021 at 04:18:22PM -0700, Nick Desaulniers wrote: > > We don't want compiler instrumentation to touch noinstr functions, which > > are annotated with the no_profile_instrument_function function > > attribute. Add a Kconfig test for this and make PGO and GCOV depend on > > it. > > > > If an architecture is using noinstr, it should denote that via this > > Kconfig value. That makes Kconfigs that depend on noinstr able to > > express dependencies in an architecturally agnostic way. > > > > Cc: Masahiro Yamada <masahiroy@kernel.org> > > Cc: Peter Oberparleiter <oberpar@linux.ibm.com> > > Link: https://lore.kernel.org/lkml/YMTn9yjuemKFLbws@hirez.programming.kicks-ass.net/ > > Link: https://lore.kernel.org/lkml/YMcssV%2Fn5IBGv4f0@hirez.programming.kicks-ass.net/ > > Suggested-by: Nathan Chancellor <nathan@kernel.org> > > Suggested-by: Peter Zijlstra <peterz@infradead.org> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > FWIW, this looks good to me: > > Acked-by: Mark Rutland <mark.rutland@arm.com> > > Catalin, Will, are you happy iwth the arm64 bit?
Looks fine to me.
Will
| |