lkml.org 
[lkml]   [2021]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/18] staging: rtl8723bs: remove VHT dead code
On Tue, Jun 22, 2021 at 11:19:36AM +0200, Hans de Goede wrote:

Hi Hans,

> Hi Fabio,
>
> > Moreover I have been quite conservative, for I left untouched HT indexes above
> > 7 which rtl8723bs doesn't support.
> >
> > So IMO I think this patch is fine as is...
> >> Perhaps this entire block can never be executed ?
> >
> > the block is executed but there's no register write happening. Just
> > updating of values which will never be fetched.
>
> Ack, my bad I was under the impression that phy_SetTxPowerByRateBase()
> would actually do a register write, but I checked and it just updates
> some unused table values, so dropping this code is fine and you can
> keep this patch for v2 of the patch set.
>
> Regards,
>
> Hans
>

thank you, what do you think about what I replied about patch 1, shall
I remove the '> 14 if block' or leave it as is? Do you think is necessary
to keep the conditions inside the block and pack them?

I would leave as is but is my opinion...

regards,

fabio

\
 
 \ /
  Last update: 2021-06-22 11:59    [W:0.754 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site