Messages in this thread | | | From | Marco Elver <> | Date | Tue, 22 Jun 2021 11:48:43 +0200 | Subject | Re: [PATCH v3 2/3] kasan: integrate the common part of two KASAN tag-based modes |
| |
On Tue, 22 Jun 2021 at 11:28, Alexander Potapenko <glider@google.com> wrote: > > > diff --git a/mm/kasan/report_tags.h b/mm/kasan/report_tags.h > > new file mode 100644 > > index 000000000000..1cb872177904 > > --- /dev/null > > +++ b/mm/kasan/report_tags.h > Why don't you make it a C file instead?
Yes, good point. report_{hw,sw}_tags.c essentially define it, but it's called by report.c code.
I think I suggested to make it a header first because there were still parts that were report_{hw,sw}_tags.c specific, and the helper function would be used by those 2 to build their version of kasan_get_bug_type(), but that doesn't seem to be the case anymore.
> > +const char *kasan_get_bug_type(struct kasan_access_info *info) > If this function has to be in the header, it should be declared as > static inline. > But I don't think it has to be there in the first place.
| |