Messages in this thread | | | Date | Wed, 23 Jun 2021 08:40:51 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v2] cpufreq: Make cpufreq_online() call driver->offline() on errors |
| |
On 22-06-21, 21:11, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Subject: [PATCH] cpufreq: Make cpufreq_online() call driver->offline() on errors > > In the CPU removal path the ->offline() callback provided by the > driver is always invoked before ->exit(), but in the cpufreq_online() > error path it is not, so ->exit() is expected to somehow know the > context in which it has been called and act accordingly. > > That is less than straightforward, so make cpufreq_online() invoke > the driver's ->offline() callback, if present, on errors before > ->exit() too. > > This only potentially affects intel_pstate. > > Fixes: 91a12e91dc39 ("cpufreq: Allow light-weight tear down and bring up of CPUs") > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > > -> v2: > * Avoid calling ->offline() after a failing ->online(). > * Add a comment regarding the expected state after calling ->init(). > * Edit the changelog a bit.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |