Messages in this thread | | | From | Jens Axboe <> | Subject | Re: [PATCH][next] block/mq-deadline: remove redundant assignment of variable ret | Date | Tue, 22 Jun 2021 15:15:45 -0600 |
| |
On Jun 22, 2021, at 3:14 PM, Bart Van Assche <bvanassche@acm.org> wrote: > > On 6/22/21 9:17 AM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Variable ret is being assigned a value at the end of the function >> and the value is never read. The assignment is redundant and can >> be removed. >> >> Addresses-Coverity: ("Unused value") >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> block/mq-deadline-main.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/block/mq-deadline-main.c b/block/mq-deadline-main.c >> index 4815e536091f..e3091d922ba2 100644 >> --- a/block/mq-deadline-main.c >> +++ b/block/mq-deadline-main.c >> @@ -639,7 +639,6 @@ static int dd_init_sched(struct request_queue *q, struct elevator_type *e) >> if (ret) >> goto free_stats; >> >> - ret = 0; >> q->elevator = eq; >> return 0; > > Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Assuming this is fallout from the recent series, we should add a fixes tag to it.
— Jens Axboe
| |