lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 090/178] regulator: bd70528: Fix off-by-one for buck123 .n_voltages setting
    Date
    From: Axel Lin <axel.lin@ingics.com>

    [ Upstream commit 0514582a1a5b4ac1a3fd64792826d392d7ae9ddc ]

    The valid selectors for bd70528 bucks are 0 ~ 0xf, so the .n_voltages
    should be 16 (0x10). Use 0x10 to make it consistent with BD70528_LDO_VOLTS.
    Also remove redundant defines for BD70528_BUCK_VOLTS.

    Signed-off-by: Axel Lin <axel.lin@ingics.com>
    Acked-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
    Link: https://lore.kernel.org/r/20210523071045.2168904-1-axel.lin@ingics.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/linux/mfd/rohm-bd70528.h | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/include/linux/mfd/rohm-bd70528.h b/include/linux/mfd/rohm-bd70528.h
    index a57af878fd0c..4a5966475a35 100644
    --- a/include/linux/mfd/rohm-bd70528.h
    +++ b/include/linux/mfd/rohm-bd70528.h
    @@ -26,9 +26,7 @@ struct bd70528_data {
    struct mutex rtc_timer_lock;
    };

    -#define BD70528_BUCK_VOLTS 17
    -#define BD70528_BUCK_VOLTS 17
    -#define BD70528_BUCK_VOLTS 17
    +#define BD70528_BUCK_VOLTS 0x10
    #define BD70528_LDO_VOLTS 0x20

    #define BD70528_REG_BUCK1_EN 0x0F
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-21 18:45    [W:4.050 / U:0.892 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site