lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 071/146] bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path
    Date
    From: Somnath Kotur <somnath.kotur@broadcom.com>

    [ Upstream commit 03400aaa69f916a376e11526cf591901a96a3a5c ]

    bnxt_ethtool_init() may have allocated some memory and we need to
    call bnxt_ethtool_free() to properly unwind if bnxt_init_one()
    fails.

    Fixes: 7c3809181468 ("bnxt_en: Refactor bnxt_init_one() and turn on TPA support on 57500 chips.")
    Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    index 3f3d13a18992..db1b89f57079 100644
    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -12746,6 +12746,7 @@ init_err_pci_clean:
    bnxt_hwrm_func_drv_unrgtr(bp);
    bnxt_free_hwrm_short_cmd_req(bp);
    bnxt_free_hwrm_resources(bp);
    + bnxt_ethtool_free(bp);
    kfree(bp->fw_health);
    bp->fw_health = NULL;
    bnxt_cleanup_pci(bp);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-21 18:29    [W:2.881 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site