lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 46/90] pinctrl: ralink: rt2880: avoid to error in calls is pin is already enabled
    Date
    From: Sergio Paracuellos <sergio.paracuellos@gmail.com>

    [ Upstream commit eb367d875f94a228c17c8538e3f2efcf2eb07ead ]

    In 'rt2880_pmx_group_enable' driver is printing an error and returning
    -EBUSY if a pin has been already enabled. This begets anoying messages
    in the caller when this happens like the following:

    rt2880-pinmux pinctrl: pcie is already enabled
    mt7621-pci 1e140000.pcie: Error applying setting, reverse things back

    To avoid this just print the already enabled message in the pinctrl
    driver and return 0 instead to not confuse the user with a real
    bad problem.

    Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
    Link: https://lore.kernel.org/r/20210604055337.20407-1-sergio.paracuellos@gmail.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
    index d0f06790d38f..0ba4e4e070a9 100644
    --- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
    +++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
    @@ -127,7 +127,7 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev,
    if (p->groups[group].enabled) {
    dev_err(p->dev, "%s is already enabled\n",
    p->groups[group].name);
    - return -EBUSY;
    + return 0;
    }

    p->groups[group].enabled = 1;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-21 18:19    [W:4.527 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site