lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ubifs: Remove a redundant null check on pointer lp
    Date
    From: Colin Ian King <colin.king@canonical.com>

    An earlier fix to replace an IS_ERR check on lp with a null check
    on lp didn't remove a following null check on lp. The second null
    check is redundant and can be removed.

    Addresses-Coverity: ("Logically dead code")
    Fixes: c770cd5190ba ("ubifs: fix an IS_ERR() vs NULL check")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    fs/ubifs/gc.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
    index 7cc22d7317ea..465beea52176 100644
    --- a/fs/ubifs/gc.c
    +++ b/fs/ubifs/gc.c
    @@ -899,8 +899,6 @@ int ubifs_gc_start_commit(struct ubifs_info *c)
    err = -ENOMEM;
    goto out;
    }
    - if (!lp)
    - break;
    idx_gc = kmalloc(sizeof(struct ubifs_gced_idx_leb), GFP_NOFS);
    if (!idx_gc) {
    err = -ENOMEM;
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-06-21 17:23    [W:3.757 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site