Messages in this thread Patch in this message | | | From | Coiby Xu <> | Subject | [RFC 02/19] staging: qlge: change LARGE_BUFFER_MAX_SIZE to 4096 | Date | Mon, 21 Jun 2021 21:48:45 +0800 |
| |
LARGE_BUFFER_MAX_SIZE=4096 could make better use of memory. This choice is consist with ixgbe and e1000 , - ixgbe sets the rx buffer's page order to 0 unless FCoE is enabled - e1000 allocs a page for a jumbo receive buffer
Signed-off-by: Coiby Xu <coiby.xu@gmail.com> --- drivers/staging/qlge/TODO | 2 -- drivers/staging/qlge/qlge.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/qlge/TODO b/drivers/staging/qlge/TODO index 449d7dca478b..0e26fac1ddc5 100644 --- a/drivers/staging/qlge/TODO +++ b/drivers/staging/qlge/TODO @@ -4,8 +4,6 @@ ql_build_rx_skb(). That function is now used exclusively to handle packets that underwent header splitting but it still contains code to handle non split cases. -* while in that area, using two 8k buffers to store one 9k frame is a poor - choice of buffer size. * in the "chain of large buffers" case, the driver uses an skb allocated with head room but only puts data in the frags. * rename "rx" queues to "completion" queues. Calling tx completion queues "rx diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 55e0ad759250..f54d38606b78 100644 --- a/drivers/staging/qlge/qlge.h +++ b/drivers/staging/qlge/qlge.h @@ -52,7 +52,7 @@ #define RX_RING_SHADOW_SPACE (sizeof(u64) + \ MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN) * sizeof(u64) + \ MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN) * sizeof(u64)) -#define LARGE_BUFFER_MAX_SIZE 8192 +#define LARGE_BUFFER_MAX_SIZE 4096 #define LARGE_BUFFER_MIN_SIZE 2048 #define MAX_CQ 128 -- 2.32.0
| |