Messages in this thread | | | Date | Mon, 21 Jun 2021 15:05:44 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL settings in stmmac_resume() |
| |
On Mon, Jun 21, 2021 at 05:45:35PM +0800, Ling Pei Lee wrote: > From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> > > After PHY received a magic packet, the PHY WOL event will be > triggered then PHY WOL event interrupt will be disarmed. > Ethtool settings will remain with WOL enabled after a S3/S4 > suspend resume cycle as expected. Hence,the driver should > reconfigure the PHY settings to reenable/disable WOL > depending on the ethtool WOL settings in the resume flow.
Please could you explain this a bit more? I'm wondering if you have a PHY driver bug. PHY WOL should remain enabled until it is explicitly disabled.
Andrew
| |