lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[External][PATCH] power: supply: bq2415x: fix deadlock in bq2415x_set_autotimer
Date
From: "Kezhou Li" <kezhou.li@tinno.com>

The bq2415x_timer_error called by bq2415x_timer_work when some error
happens, and then calls cancel_delayed_work_sync(&bq->work). Finally
this function is waiting for the work to finish but the work is
waiting for the return of the function. So it causes a deadlock.

Signed-off-by: Kezhou Li <kezhou.li@tinno.com>
---
drivers/power/supply/bq2415x_charger.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
index 5724001..7889edb 100644
--- a/drivers/power/supply/bq2415x_charger.c
+++ b/drivers/power/supply/bq2415x_charger.c
@@ -862,8 +862,6 @@ static void bq2415x_set_autotimer(struct bq2415x_device *bq, int state)
schedule_delayed_work(&bq->work, BQ2415X_TIMER_TIMEOUT * HZ);
bq2415x_exec_command(bq, BQ2415X_TIMER_RESET);
bq->timer_error = NULL;
- } else {
- cancel_delayed_work_sync(&bq->work);
}

mutex_unlock(&bq2415x_timer_mutex);
--
1.9.1
\
 
 \ /
  Last update: 2021-06-21 14:43    [W:0.031 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site