Messages in this thread | | | Date | Mon, 21 Jun 2021 11:39:23 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v1 1/1] spi: Remove unneeded parentheses in spi_map_buf() |
| |
On Sat, Jun 19, 2021 at 02:15:26PM +0300, Andy Shevchenko wrote: > The boolean expression to get kmap_buf is hard to read due to > too many unneeded parentheses. Remove them for good.
> - const bool kmap_buf = ((unsigned long)buf >= PKMAP_BASE && > - (unsigned long)buf < (PKMAP_BASE + > - (LAST_PKMAP * PAGE_SIZE))); > + const bool kmap_buf = (unsigned long)buf >= PKMAP_BASE && > + (unsigned long)buf < (PKMAP_BASE + LAST_PKMAP * PAGE_SIZE);
No, I think this makes things worse - to the extent there's an issue here it's not excessive brackets. [unhandled content-type:application/pgp-signature] | |