Messages in this thread | | | Date | Mon, 21 Jun 2021 12:56:31 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 3/5] staging: vchiq: Move vchiq char driver to its own file |
| |
On Sun, Jun 20, 2021 at 06:26:34PM +0530, Ojaswin Mujoo wrote: > +/* read a user pointer value from an array pointers in user space */ > +static inline int vchiq_get_user_ptr(void __user **buf, void __user *ubuf, int index) > +{ > + int ret; > + > + if (in_compat_syscall()) { > + compat_uptr_t ptr32; > + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ When I'm reviewing these sorts of patches then what I'm trying to verify is that you are not a UMN "researcher" trying to change the code without anyone noticing. In the orignal code, there was no blank line here
> + compat_uptr_t __user *uptr = ubuf;
but there was a blank line here.
> + ret = get_user(ptr32, uptr + index); > + *buf = compat_ptr(ptr32); > + } else {
These sorts of minor white space changes make it hard to verify the code in an automated way.
> + uintptr_t ptr, __user *uptr = ubuf; > + > + ret = get_user(ptr, uptr + index); > + *buf = (void __user *)ptr; > + } > + > + return ret; > +} > +
regards, dan carpenter
| |