lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] fuse: Send FUSE_WRITE_KILL_SUIDGID for killpriv v1
On Fri, 23 Apr 2021 at 17:19, Connor Kuehl <ckuehl@redhat.com> wrote:
>
> FUSE doesn't seem to be adding the FUSE_WRITE_KILL_SUIDGID flag on write
> requests for FUSE connections that support FUSE_HANDLE_KILLPRIV but not
> FUSE_HANDLE_KILLPRIV_V2.
>
> However, the FUSE userspace header states:
>
> FUSE_HANDLE_KILLPRIV: fs handles killing suid/sgid/cap on
> write/chown/trunc
> ^^^^^
>
> To improve backwards compatibility with file servers that don't support
> FUSE_HANDLE_KILLPRIV_V2, add the FUSE_WRITE_KILL_SUIDGID flag to write
> requests if FUSE_HANDLE_KILLPRIV has been negotiated -OR- if the
> conditions for FUSE_HANDLE_KILLPRIV_V2 support are met.


If server does not support FUSE_HANDLE_KILLPRIV_V2, then it does not
support FUSE_WRITE_KILL_SUIDGID either. The two were introduced
together and the latter is only meaningful if the
FUSE_HANDLE_KILLPRIV_V2 feature was negotiated.

What am I missing?

Thanks,
Miklos

\
 
 \ /
  Last update: 2022-09-17 16:10    [W:0.038 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site