lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ASoC: fsl-asoc-card: change dev_err to dev_dbg for defer probe
Hi Shengjiu,

On Wed, Jun 2, 2021 at 3:59 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> Don't need to print error message for defer probe
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> sound/soc/fsl/fsl-asoc-card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
> index 4f55b316cf0f..b40ba910ae9d 100644
> --- a/sound/soc/fsl/fsl-asoc-card.c
> +++ b/sound/soc/fsl/fsl-asoc-card.c
> @@ -709,7 +709,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
> of_node_put(framemaster);
>
> if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) {
> - dev_err(&pdev->dev, "failed to find codec device\n");
> + dev_dbg(&pdev->dev, "failed to find codec device\n");
> ret = -EPROBE_DEFER;

This looks good:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

My previous suggestion of using dev_err_probe() would make the message
never to be printed.

Thanks

\
 
 \ /
  Last update: 2021-06-22 04:17    [W:0.179 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site