Messages in this thread | | | Subject | Re: linux-next: Fixes tag needs some work in the kvm tree | From | Paolo Bonzini <> | Date | Tue, 22 Jun 2021 01:37:29 +0200 |
| |
On 22/06/21 00:18, Stephen Rothwell wrote: > Hi all, > > In commit > > ade74e1433f3 ("KVM: x86/mmu: Grab nx_lpage_splits as an unsigned long before division") > > Fixes tag > > Fixes: 7ee093d4f3f5 ("KVM: switch per-VM stats to u64") > > has these problem(s): > > - Target SHA1 does not exist > > Maybe you meant > > Fixes: e3cb6fa0e2bf ("KVM: switch per-VM stats to u64") > > It is very hard to get the commit SHA right when the commit you are > "fixing" is after the fix commit :-)
Yeah, that Fixes tag should have been removed since the patch can be kept separate (does not have to be squashed).
Paolo
| |