lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next] net/sched: cls_flower: fix resetting of ether proto mask
    On Thu, Jun 17, 2021 at 10:51:02PM +0300, Vladimir Oltean wrote:
    > On Thu, Jun 17, 2021 at 07:41:55PM +0300, Vladimir Oltean wrote:
    > > On Thu, Jun 17, 2021 at 07:14:35PM +0300, Vadym Kochan wrote:

    [snip excellent problem analysis]

    > So maybe it is the flow dissector we need to fix, to make it give us an
    > additional pure EtherType if asked for, make tc-flower use that
    > dissector key instead, and then revert Jamal's user space patch, and we
    > should all install our tc filters as:
    >
    > tc filter add dev sw1p0 ingress handle 11 protocol all flower eth_type 0x8864 skip_hw action drop
    >
    > ?

    I like this solution. To be more explicit, the plan becomes:

    1. Add FLOW_DISSECTOR_KEY_ETH_TYPE and struct flow_dissector_key_eth_type.
    2. Have skb flow dissector use it.
    3. Userspace does not set TCA_FLOWER_KEY_ETH_TYPE automagically
    anymore. cls_flower takes basic.n_proto from struct tcf_proto.
    4. Add eth_type to the userspace and use it to set TCA_FLOWER_KEY_ETH_TYPE
    5. Existence of TCA_FLOWER_KEY_ETH_TYPE triggers new eth_type dissector.

    IMHO this neatly solves non-vlan protocol match case.

    What should we do with the VLANs then? Should we have vlan_pure_ethtype
    and cvlan_pure_ethtype as additional keys?

    >
    > Or maybe just be like you, say I don't care about any of that, I just
    > want it to behave as before, and simply revert Boris's patch. Ok, maybe

    FTR I fully support reverting the patch. Please accept my apologies for
    breaking the HW offload and big thanks to Vadym for finding it.

    I will send the revert shortly.

    Thanks,
    Boris.
    [unhandled content-type:application/pkcs7-signature]
    \
     
     \ /
      Last update: 2021-06-21 10:33    [W:3.224 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site