Messages in this thread | | | Subject | Re: [PATCH] selftests/sgx: remove checks for file execute permissions | From | Reinette Chatre <> | Date | Mon, 21 Jun 2021 14:08:10 -0700 |
| |
Hi Dave,
On 6/21/2021 12:05 PM, Dave Hansen wrote: > > The SGX selftests can fail for a bunch of non-obvious reasons > like 'noexec' permissions on /dev (which is the default *EVERYWHERE* > it seems). > > A new test mistakenly also looked for +x permission on the > /dev/sgx_enclave. File execute permissions really only apply to > the ability of execve() to work on a file, *NOT* on the ability > for an application to map the file with PROT_EXEC. SGX needs to > mmap(PROT_EXEC), but doesn't need to execve() the device file. > > Remove the check. > > Fixes: 4284f7acb78b ("selftests/sgx: Improve error detection and messages") > Reported-by: Tim Gardner <tim.gardner@canonical.com> > Cc: Jarkko Sakkinen <jarkko@kernel.org> > Cc: Reinette Chatre <reinette.chatre@intel.com> > Cc: Dave Hansen <dave.hansen@linux.intel.com> > Cc: Shuah Khan <shuah@kernel.org> > Cc: linux-sgx@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > Cc: linux-kernel@vger.kernel.org >
Thank you very much for fixing this. With this applied the SGX tests are able to run again on my system.
Tested-by: Reinette Chatre <reinette.chatre@intel.com>
I think it is missing a "Signed-off-by".
Reinette
| |