lkml.org 
[lkml]   [2021]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 093/178] phy: phy-mtk-tphy: Fix some resource leaks in mtk_phy_init()
    Date
    From: Tiezhu Yang <yangtiezhu@loongson.cn>

    [ Upstream commit aaac9a1bd370338ce372669eb9a6059d16b929aa ]

    Use clk_disable_unprepare() in the error path of mtk_phy_init() to fix
    some resource leaks.

    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
    Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
    Link: https://lore.kernel.org/r/1621420659-15858-1-git-send-email-yangtiezhu@loongson.cn
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/phy/mediatek/phy-mtk-tphy.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
    index cdbcc49f7115..731c483a04de 100644
    --- a/drivers/phy/mediatek/phy-mtk-tphy.c
    +++ b/drivers/phy/mediatek/phy-mtk-tphy.c
    @@ -949,6 +949,8 @@ static int mtk_phy_init(struct phy *phy)
    break;
    default:
    dev_err(tphy->dev, "incompatible PHY type\n");
    + clk_disable_unprepare(instance->ref_clk);
    + clk_disable_unprepare(instance->da_ref_clk);
    return -EINVAL;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-21 18:46    [W:2.430 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site