Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH] drivers/nvme/host: Use kobj_to_dev() API | Date | Mon, 21 Jun 2021 03:11:05 +0000 |
| |
Keith,
On 6/20/21 10:34, Keith Busch wrote: > On Sat, Jun 19, 2021 at 01:01:34PM +0800, 周传高 wrote: >>> On Fri, Jun 18, 2021 at 07:10:58AM -0700, zhouchuangao wrote: >>>> Use kobj_to_dev() API instead of container_of(). >>> Why? That just makes the code harder to read. >> In my opinion, the kobj_to_dev() interface is provided by the kernel so that >> we can get device based on kobj without having to pass more parameters. >> I think it's easier to use. > This same patch has been proposed and rejected numerous times. Do we > need to place a comment in the code to prevent future requests? > > http://lists.infradead.org/pipermail/linux-nvme/2021-March/023316.html > http://lists.infradead.org/pipermail/linux-nvme/2021-February/023060.html > http://lists.infradead.org/pipermail/linux-nvme/2020-September/019462.html > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme >
Just sent a patch with your suggested-by see if that is useful.
| |