lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v1 1/5] cpuidle: teo: Cosmetic modifications of teo_update()
Date
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>

Rename a local variable in teo_update() so that its purpose is better
reflected by its name and use one more local variable in the loop
over the CPU idle states in that function to make the code somewhat
easier to read.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpuidle/governors/teo.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

Index: linux-pm/drivers/cpuidle/governors/teo.c
===================================================================
--- linux-pm.orig/drivers/cpuidle/governors/teo.c
+++ linux-pm/drivers/cpuidle/governors/teo.c
@@ -117,7 +117,7 @@ static DEFINE_PER_CPU(struct teo_cpu, te
static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
{
struct teo_cpu *cpu_data = per_cpu_ptr(&teo_cpus, dev->cpu);
- int i, idx_hit = 0, idx_timer = 0;
+ int i, idx_timer = 0, idx_duration = 0;
unsigned int hits, misses;
u64 measured_ns;

@@ -156,14 +156,15 @@ static void teo_update(struct cpuidle_dr
* states matching the sleep length and the measured idle duration.
*/
for (i = 0; i < drv->state_count; i++) {
+ s64 target_residency_ns = drv->states[i].target_residency_ns;
unsigned int early_hits = cpu_data->states[i].early_hits;

cpu_data->states[i].early_hits -= early_hits >> DECAY_SHIFT;

- if (drv->states[i].target_residency_ns <= cpu_data->sleep_length_ns) {
+ if (target_residency_ns <= cpu_data->sleep_length_ns) {
idx_timer = i;
- if (drv->states[i].target_residency_ns <= measured_ns)
- idx_hit = i;
+ if (target_residency_ns <= measured_ns)
+ idx_duration = i;
}
}

@@ -181,11 +182,11 @@ static void teo_update(struct cpuidle_dr
misses = cpu_data->states[idx_timer].misses;
misses -= misses >> DECAY_SHIFT;

- if (idx_timer == idx_hit) {
+ if (idx_timer == idx_duration) {
hits += PULSE;
} else {
misses += PULSE;
- cpu_data->states[idx_hit].early_hits += PULSE;
+ cpu_data->states[idx_duration].early_hits += PULSE;
}

cpu_data->states[idx_timer].misses = misses;


\
 
 \ /
  Last update: 2021-06-02 20:20    [W:0.155 / U:1.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site