lkml.org 
[lkml]   [2021]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5.10 35/38] rtnetlink: Fix missing error code in rtnl_bridge_notify()
On Sat, Jun 19, 2021 at 02:58:28AM +0300, Alexander Tsoy wrote:
> В Ср, 16/06/2021 в 17:33 +0200, Greg Kroah-Hartman пишет:
> > From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> >
> > [ Upstream commit a8db57c1d285c758adc7fb43d6e2bad2554106e1 ]
> >
> > The error code is missing in this code scenario, add the error code
> > '-EINVAL' to the return value 'err'.
> >
> > Eliminate the follow smatch warning:
> >
> > net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
> > 'err'.
>
> This patch breaks systemd-resolved. It is 100% reproducible on two of
> my systems, but there are also systems where I cannot reproduce it. The
> problem manifests itself as SERVFAIL on every DNS query.
>
> Just reverting this patch from 5.10.45 fixes the problem for me.

Is Linus's tree also broken for you? It should be reverted there first.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-06-19 08:54    [W:0.069 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site