lkml.org 
[lkml]   [2021]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 10/12] trace: Add osnoise tracer
On Tue, 15 Jun 2021 11:28:49 +0200
Daniel Bristot de Oliveira <bristot@redhat.com> wrote:

> diff --git a/kernel/trace/trace_osnoise.h b/kernel/trace/trace_osnoise.h
> new file mode 100644
> index 000000000000..34c7b80f9e12
> --- /dev/null
> +++ b/kernel/trace/trace_osnoise.h
> @@ -0,0 +1,9 @@
> +int __weak osnoise_arch_register(void)
> +{
> + return 0;
> +}
> +
> +void __weak osnoise_arch_unregister(void)
> +{
> + return;
> +}

No reason to put the above in a header file. In fact, as it is code, it
should not be in a header file. Keep it in the trace_osnoise.c.

-- Steve

\
 
 \ /
  Last update: 2021-06-18 20:28    [W:0.098 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site