lkml.org 
[lkml]   [2021]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFCv1 8/8] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER
    Date
    devm_phy_create can return -EPROBE_DEFER if the phy-supply is not ready
    yet. Silence this warning as the driver framework will re-attempt
    registering the PHY. Use dev_err_probe() for phy resources to indicate
    the deferral reason when waiting for the resource to come up.

    Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Signed-off-by: Anand Moon <linux.amoon@gmail.com>
    ---
    drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c
    index d5edd31686bb..bd624781d914 100644
    --- a/drivers/phy/amlogic/phy-meson8b-usb2.c
    +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c
    @@ -332,8 +332,8 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev)

    phy = devm_phy_create(&pdev->dev, NULL, &phy_meson8b_usb2_ops);
    if (IS_ERR(phy)) {
    - dev_err(&pdev->dev, "failed to create PHY\n");
    - return PTR_ERR(phy);
    + ret = PTR_ERR(phy);
    + return dev_err_probe(&pdev->dev, ret, "failed to create PHY\n");
    }

    phy_set_drvdata(phy, priv);
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-06-17 21:45    [W:2.086 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site