lkml.org 
[lkml]   [2021]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] serial: amba-pl011: add RS485 support
    From
    Date

    Hi,

    On 16.06.21 at 08:18, Jiri Slaby wrote:
            mdelay(port->rs485.delay_rts_before_send);
    >
    > This is up to 1 second delay with interrupts disabled. Definitely not nice. 8250 clamps this to 100 ms at least, why did you choose 1000 ms?
    >

    AFAICS the 8250 driver does not clamp values read from the device tree property "rs485-rts-delay"
    (set by uart_get_rs485_mode()). Is this on purpose?

    Regards,
    Lino

    \
     
     \ /
      Last update: 2021-06-17 19:45    [W:3.414 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site