lkml.org 
[lkml]   [2021]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] iommu/vt-d: Fix W=1 clang warning in intel/perf.c
    On Thu, Jun 17, 2021 at 7:54 AM Joerg Roedel <joro@8bytes.org> wrote:
    >
    > From: Joerg Roedel <jroedel@suse.de>
    >
    > Fix this warning when compiled with clang and W=1:
    >
    > drivers/iommu/intel/perf.c:16: warning: Function parameter or member 'latency_lock' not described in 'DEFINE_SPINLOCK'
    > drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead

    I think these warnings are actually produced by kernel-doc? (not clang)

    >
    > Cc: Lu Baolu <baolu.lu@linux.intel.com>
    > Reported-by: kernel test robot <lkp@intel.com>
    > Fixes: 55ee5e67a59a ("iommu/vt-d: Add common code for dmar latency performance monitors")
    > Signed-off-by: Joerg Roedel <jroedel@suse.de>
    > ---
    > drivers/iommu/intel/perf.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/iommu/intel/perf.c b/drivers/iommu/intel/perf.c
    > index 73b7ec705552..0e8e03252d92 100644
    > --- a/drivers/iommu/intel/perf.c
    > +++ b/drivers/iommu/intel/perf.c
    > @@ -1,5 +1,5 @@
    > // SPDX-License-Identifier: GPL-2.0
    > -/**
    > +/*
    > * perf.c - performance monitor
    > *
    > * Copyright (C) 2021 Intel Corporation
    > --
    > 2.31.1
    >
    > --
    > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
    > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
    > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210617145339.2692-1-joro%408bytes.org.



    --
    Thanks,
    ~Nick Desaulniers

    \
     
     \ /
      Last update: 2021-06-17 19:18    [W:3.632 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site