Messages in this thread | | | Date | Thu, 17 Jun 2021 23:17:19 +0800 | From | Boqun Feng <> | Subject | Re: [PATCH] locking/lockdep: correct the description error for check_redundant() |
| |
On Thu, Jun 17, 2021 at 11:05:23PM +0800, Xiongwei Song wrote: > From: Xiongwei Song <sxwjean@gmail.com> > > If there is no matched result, check_redundant() will return BFS_RNOMATCH. > > Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
Good catch!
Nit: you may want to capitalize the first letter after subsystem tag in the patch title, like:
"locking/lockdep: Correct ..."
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards, Boqun
> --- > kernel/locking/lockdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index cfe0f4374594..1f126ca7fbd7 100644 > --- a/kernel/locking/lockdep.c > +++ b/kernel/locking/lockdep.c > @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask) > * <target> or not. If it can, <src> -> <target> dependency is already > * in the graph. > * > - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if > + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if > * any error appears in the bfs search. > */ > static noinline enum bfs_result > -- > 2.30.2 >
| |