Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Thu, 17 Jun 2021 15:27:07 +0200 | Subject | Re: [PATCH V2 2/3] cpufreq: intel_pstate: Migrate to ->exit() callback instead of ->stop_cpu() |
| |
On Wed, Jun 16, 2021 at 8:41 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > commit 367dc4aa932b ("cpufreq: Add stop CPU callback to cpufreq_driver > interface") added the stop_cpu() callback to allow the drivers to do > clean up before the CPU is completely down and its state can't be > modified. > > At that time the CPU hotplug framework used to call the cpufreq core's > registered notifier for different events like CPU_DOWN_PREPARE and > CPU_POST_DEAD. The stop_cpu() callback was called during the > CPU_DOWN_PREPARE event. > > This is no longer the case, cpuhp_cpufreq_offline() is called only once > by the CPU hotplug core now and we don't really need two separate > callbacks for cpufreq drivers, i.e. stop_cpu() and exit(), as everything > can be done from the exit() callback itself. > > Migrate to using the exit() callback instead of stop_cpu(). > > Cc: Dirk Brandewie <dirk.brandewie@gmail.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/intel_pstate.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 0e69dffd5a76..37ad42926904 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -2374,17 +2374,11 @@ static int intel_pstate_cpu_online(struct cpufreq_policy *policy) > return 0; > } > > -static void intel_pstate_stop_cpu(struct cpufreq_policy *policy) > -{ > - pr_debug("CPU %d stopping\n", policy->cpu); > - > - intel_pstate_clear_update_util_hook(policy->cpu); > -} > - > static int intel_pstate_cpu_exit(struct cpufreq_policy *policy) > { > pr_debug("CPU %d exiting\n", policy->cpu); > > + intel_pstate_clear_update_util_hook(policy->cpu);
This addresses the ->exit case, but it doesn't address the ->offline case AFAICS.
> policy->fast_switch_possible = false; > > return 0; > @@ -2451,7 +2445,6 @@ static struct cpufreq_driver intel_pstate = { > .resume = intel_pstate_resume, > .init = intel_pstate_cpu_init, > .exit = intel_pstate_cpu_exit, > - .stop_cpu = intel_pstate_stop_cpu, > .offline = intel_pstate_cpu_offline, > .online = intel_pstate_cpu_online, > .update_limits = intel_pstate_update_limits, > --
| |