lkml.org 
[lkml]   [2021]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] usb: gadget: eem: fix echo command packet response issue
On Wed, Jun 16, 2021 at 07:51:42PM +0800, Linyu Yuan wrote:
> From: Linyu Yuan <linyyuan@codeaurora.com>
>
> when receive eem echo command, it will send a response,
> but queue this response to the usb request which allocate
> from gadget device endpoint zero,
> and transmit the request to IN endpoint of eem interface.
>
> on dwc3 gadget, it will trigger following warning in function
> __dwc3_gadget_ep_queue(),
>
> if (WARN(req->dep != dep, "request %pK belongs to '%s'\n",
> &req->request, req->dep->name))
> return -EINVAL;

Is this really a problem? I am guessing the request will not work at
all? Or just warn and continue with it?

How was this ever working?

>
> fix it by allocating a usb request from IN endpoint of eem interface,
> and transmit the usb request to same IN endpoint of eem interface.
>
> Signed-off-by: Linyu Yuan <linyyuan@codeaurora.com>
> ---

What commit does this fix? Should it be backported to older stable
kernels? If so, how far back?

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-06-17 15:23    [W:5.047 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site