lkml.org 
[lkml]   [2021]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next v3] media: staging: atomisp: use list_splice_init in atomisp_compat_css20.c
From
Date
Thank you for your advice.

I'll follow your advice strictly.

Best Regards.


在 2021/6/17 20:41, Andy Shevchenko 写道:
> On Thu, Jun 17, 2021 at 08:14:28PM +0800, libaokun (A) wrote:
>> Sorry, I only tested it with 'x86_64.config'.
>>
>> I'm about to send a patch v4 with the changes to fix the error under your
>> config.
> Please, do not top-post!
>
>
> Problem here that you tested without additional warnings enabled.
>
> Next time try to start with `make W=1 ...`
>
> If you have installed Sparse tool, the better option would be
> `make W=1 C=1 CF=-D__CHECK_ENDIAN__ ...`
>
>> 在 2021/6/17 16:52, kernel test robot 写道:
>>> Hi Baokun,
>>>
>>> Thank you for the patch! Yet something to improve:
>>>
>>> [auto build test ERROR on next-20210616]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Baokun-Li/media-staging-atomisp-use-list_splice_init-in-atomisp_compat_css20-c/20210617-043443
>>> base: c7d4c1fd91ab4a6d2620497921a9c6bf54650ab8
>>> config: i386-allyesconfig (attached as .config)
>>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>>> reproduce (this is a W=1 build):
>>> # https://github.com/0day-ci/linux/commit/05c714d7b4e1722a75f949e40c5305f3ba28d048
>>> git remote add linux-review https://github.com/0day-ci/linux
>>> git fetch --no-tags linux-review Baokun-Li/media-staging-atomisp-use-list_splice_init-in-atomisp_compat_css20-c/20210617-043443
>>> git checkout 05c714d7b4e1722a75f949e40c5305f3ba28d048
>>> # save the attached .config to linux build tree
>>> make W=1 ARCH=i386
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c: In function 'atomisp_css_stop':
>>>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2156:50: error: 'struct atomisp_sub_device' has no member named 'asd'
>>> 2156 | list_splice_init(&asd->metadata_in_css[i], &asd->asd->metadata[i]);
>>> | ^~
>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2157:49: error: 'struct atomisp_sub_device' has no member named 'asd'
>>> 2157 | list_splice_init(&asd->metadata_ready[i], &asd->asd->metadata[i]);
>>> | ^~
>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2107:31: warning: unused variable 'md_buf' [-Wunused-variable]
>>> 2107 | struct atomisp_metadata_buf *md_buf;
>>> | ^~~~~~
>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2106:26: warning: unused variable 'dis_buf' [-Wunused-variable]
>>> 2106 | struct atomisp_dis_buf *dis_buf;
>>> | ^~~~~~~

\
 
 \ /
  Last update: 2021-06-17 14:54    [W:0.068 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site