Messages in this thread | | | From | "Song Bao Hua (Barry Song)" <> | Subject | RE: [PATCH v4 2/4] topology: use bin_attribute to avoid buff overflow | Date | Thu, 17 Jun 2021 11:03:40 +0000 |
| |
> -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Thursday, June 17, 2021 10:56 PM > To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com> > Cc: andriy.shevchenko@linux.intel.com; linux-kernel@vger.kernel.org; > linux@rasmusvillemoes.dk; rafael@kernel.org; akpm@linux-foundation.org; > rdunlap@infradead.org; agordeev@linux.ibm.com; sbrivio@redhat.com; > jianpeng.ma@intel.com; yury.norov@gmail.com; valentin.schneider@arm.com; > peterz@infradead.org; bristot@redhat.com; guodong.xu@linaro.org; > tangchengchang <tangchengchang@huawei.com>; Zengtao (B) > <prime.zeng@hisilicon.com>; yangyicong <yangyicong@huawei.com>; > tim.c.chen@linux.intel.com; tiantao (H) <tiantao6@hisilicon.com>; Jonathan > Cameron <jonathan.cameron@huawei.com>; Linuxarm <linuxarm@huawei.com> > Subject: Re: [PATCH v4 2/4] topology: use bin_attribute to avoid buff overflow > > On Thu, Jun 17, 2021 at 10:19:08PM +1200, Barry Song wrote: > > From: Tian Tao <tiantao6@hisilicon.com> > > > > Reading sys/devices/system/cpu/cpuX/topology/ returns cpu topology. > > However, the size of this file is limited to PAGE_SIZE because of the > > limitation for sysfs attribute. so we use bin_attribute instead of > > attribute to avoid NR_CPUS too big to cause buff overflow. > > > > Link: > https://lore.kernel.org/lkml/20210319041618.14316-2-song.bao.hua@hisilicon > .com/ > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > > Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > > As with the other patch, you have to also sign off on this as well. > Ok. Will add my s-o-b for patch 1-3.
> The link is pointing to a v5 of a different patch series, why put that > here?
This patchset originated from the discussion of that one in the link tag.
Jonathan and me were trying to add a cluster topology level. And that one exposed the problem this patchset is addressing.
> > thanks, > > greg k-h
Thanks Barry
| |