lkml.org 
[lkml]   [2021]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Re: [PATCH] scsi: ufs: Add indent for code alignment
From
Date
On Thu, 2021-06-17 at 10:28 +0900, Keoseong Park wrote:
> > On Thu, 2021-06-10 at 13:07 +0900, Keoseong Park wrote:
> > > Add indentation to return statement.
> > []
> > > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > []
> > > @@ -903,7 +903,7 @@ static inline bool
> > > ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
> > >   else
> > >   return false;
> > >  #else
> > > -return true;
> > > + return true;
> > >  #endif
> > >  }
> > >  
> >
> > Perhaps a little refactoring instead:
> > ---
> > drivers/scsi/ufs/ufshcd.h | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > index c98d540ac044d..ed89839476b3b 100644
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/drivers/scsi/ufs/ufshcd.h
> > @@ -894,15 +894,11 @@ static inline bool
> > ufshcd_is_rpm_autosuspend_allowed(struct ufs_hba *hba)
> > static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
> > {
> > /* DWC UFS Core has the Interrupt aggregation feature but is not
> > detectable*/
> > -#ifndef CONFIG_SCSI_UFS_DWC
> > - if ((hba->caps & UFSHCD_CAP_INTR_AGGR) &&
> > - !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR))
> > + if (IS_ENABLED(CONFIG_SCSI_UFS_DWC))
> > return true;
> > - else
> > - return false;
> > -#else
> > -return true;
> > -#endif
> > +
> > + return (hba->caps & UFSHCD_CAP_INTR_AGGR) &&
> > + !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR);
> > }
> >
> > static inline bool ufshcd_can_aggressive_pc(struct ufs_hba *hba)
> >
>
> Hello Joe,
> Thanks for your advice.
> As you mentioned, refactoring looks good.
> However, since the content does not match the title, can I submit a
> patch with a new title?

Yes of course.

\
 
 \ /
  Last update: 2021-06-17 22:57    [W:0.037 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site