lkml.org 
[lkml]   [2021]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v4 02/10] net: sparx5: add the basic sparx5 driver
From
Date
Hi Philipp,

Thanks for your comments,

On Tue, 2021-06-15 at 15:22 +0200, Philipp Zabel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Steen,
>
> On Tue, 2021-06-15 at 10:50 +0200, Steen Hegelund wrote:
> > This adds the Sparx5 basic SwitchDev driver framework with IO range
> > mapping, switch device detection and core clock configuration.
> >
> > Support for ports, phylink, netdev, mactable etc. are in the following
> > patches.
> >
> > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> > Signed-off-by: Bjarni Jonasson <bjarni.jonasson@microchip.com>
> > Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com>
> [...]
> > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> > b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> > new file mode 100644
> > index 000000000000..892bbbaacbd6
> > --- /dev/null
> > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> > @@ -0,0 +1,743 @@
> [...]
> > +static int mchp_sparx5_probe(struct platform_device *pdev)
> > +{
> [...]
> > + /* Do switch core reset if available */
> > + reset = devm_reset_control_get_optional_shared(&pdev->dev, "switch");
>
> Please don't ignore errors here. For example:
>
> if (IS_ERR(reset))
> return dev_err_probe(&pdev->dev, PTR_ERR(reset),
> "Failed to get reset.\n");
>
> > reset_control_reset(reset);

Yes, I will add an error message.

>
> regards
> Philipp


--
BR
Steen

-=-=-=-=-=-=-=-=-=-=-=-=-=-=
steen.hegelund@microchip.com


\
 
 \ /
  Last update: 2021-06-16 08:21    [W:0.057 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site