Messages in this thread | | | Date | Wed, 16 Jun 2021 12:07:28 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH Part1 RFC v3 11/22] x86/sev: Add helper for validating pages in early enc attribute changes |
| |
On Mon, Jun 14, 2021 at 04:01:44PM -0500, Brijesh Singh wrote: > Now that we have to defined a Linux specific reason set, we could > potentially define a new error code "Invalid response code" and return
I don't understand - you have a WARN for the following check:
if (WARN(GHCB_MSR_PSC_RESP_VAL(val), "Failed to change page state to '%s' paddr 0x%lx error 0x%llx\n",
what's wrong with doing:
if (WARN(GHCB_RESP_CODE(val) != GHCB_MSR_PSC_RESP, "Wrong PSC response code: 0x%x\n", (unsigned int)GHCB_RESP_CODE(val))) goto e_term;
above it too?
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |