lkml.org 
[lkml]   [2021]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] recordmcount: Correct st_shndx handling
On Tue, 15 Jun 2021 14:47:20 +0800
Mark-PK Tsai <mark-pk.tsai@mediatek.com> wrote:

> One should only use st_shndx when >SHN_UNDEF and <SHN_LORESERVE. When
> SHN_XINDEX, then use .symtab_shndx. Otherwise use 0.
>
> This handles the case: st_shndx >= SHN_LORESERVE && st_shndx != SHN_XINDEX.
>
> Reported-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Tested-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>

Please explain the two signed-off-by's above. If you are just tweaking
Peter's original patch, please add at the start:

From: Peter Zijlstra (Intel) <peterz@infradead.org>

And then just above your signed off by, add what you changed:

Tested-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
[ Changed something ]
Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>

But state what you changed.

Thanks!

-- Steve

\
 
 \ /
  Last update: 2021-06-15 17:42    [W:0.035 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site