Messages in this thread | | | Subject | Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files | From | "wangyanan (Y)" <> | Date | Tue, 15 Jun 2021 18:05:04 +0800 |
| |
On 2021/6/15 17:48, Marc Zyngier wrote: > On Tue, 15 Jun 2021 04:50:19 +0100, > Yanan Wang <wangyanan55@huawei.com> wrote: >> These fixes introduce no functional change but just adjustment about >> coding style issues for ARM64 vgic code. They mainly include identation >> fix of function parameters/arguments, identation fix of structure >> initialization, identation fix of comment, also the deletion of some >> superfluous space lines. > Please don't. This sort of patches bring little value, and make the > backporting of important fixes more difficult because of pointless > context change. Oh, this is an point that I didn't notice but indeed worths considering. > Fixing these cosmetic details is fine when you are modifying the > code. But as a standalone patch, this brings more pain than benefit. Ok, I will just drop this stuff. Sorry for the noise.
Thanks, Yanan > Thanks, > > M. >
| |